remove old ad #1872
remove old ad #1872
Conversation
samccann
added
backport-2.15
There was a problem hiding this comment.
Rather than commenting, let's just delete the line. If we need to restore it, we have git history and can revert the commit.
Commenting the line increases clutter imo and reduces the risk that it will be accidentally restored. I suppose there might also be a negligible performance reason for removing the line too. It's one less thing to parse.
docs/docsite/rst/conf.py
Outdated
| @@ -217,7 +217,7 @@ | |||
|
|
|||
| html_theme_options = { | |||
| 'canonical_url': "https://docs.ansible.com/ansible/latest/", | |||
| 'hubspot_id': '330046', | |||
| # 'hubspot_id': '330046', | |||
There was a problem hiding this comment.
| # 'hubspot_id': '330046', |
|
Hmm. Is it just me or is the left nav cut off at the bottom?
|
|
I've kicked off a run to deploy this branch to test: https://github.com/ansible/ansible-documentation/actions/runs/10827409830 |
|
Yeah it looks like the left nav is truncated on stage too: https://ansible-community.github.io/package-doc-builds/ |
|
Closed and re-opened to check the RTD preview build. It looks like there's still a reference to the |
|
Closing this - the problem I think is in the sphinx ansible theme itself - https://github.com/ansible-community/sphinx_ansible_theme/blob/main/src/sphinx_ansible_theme/extranav.html So will remove the ad from there. |
|
@samccann It might still be worth removing that line from the conf file after you make the change to the sphinx theme. |
|
A good point. |
oraNod
added
the
backport-2.18
The Ad at the bottom left of docs pages stopped working when ansible.com was revamped, so ...time to remove it!