Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAP-32490: Konflux build pipelines for Ansible Chatbot service #4

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

mabulgu
Copy link

@mabulgu mabulgu commented Oct 17, 2024

Description

Please see AAP-32490

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Run the pipelines via Konflux UI

@mabulgu mabulgu marked this pull request as ready for review October 17, 2024 11:21
@mabulgu mabulgu marked this pull request as draft October 17, 2024 11:23
@mabulgu mabulgu changed the title [WIP] AAP-32490: Konflux build pipelines for Ansible Chatbot service AAP-32490: Konflux build pipelines for Ansible Chatbot service Oct 17, 2024
@mabulgu mabulgu marked this pull request as ready for review October 17, 2024 12:18
@jameswnl
Copy link

we need to go to the console dot ui to create Konflux application/component and start from there.

@mabulgu
Copy link
Author

mabulgu commented Oct 17, 2024

we need to go to the console dot ui to create Konflux application/component and start from there.

On it thanks! I did not know we are able to test it before merging. Updating the dec part reg. that

@mabulgu mabulgu marked this pull request as draft October 17, 2024 14:22
@mabulgu
Copy link
Author

mabulgu commented Oct 17, 2024

@jameswnl converted this PR to draft as I found out I am able to test it before the merge.

@mabulgu mabulgu changed the title AAP-32490: Konflux build pipelines for Ansible Chatbot service [WIP] AAP-32490: Konflux build pipelines for Ansible Chatbot service Oct 17, 2024
@mabulgu mabulgu changed the title [WIP] AAP-32490: Konflux build pipelines for Ansible Chatbot service AAP-32490: Konflux build pipelines for Ansible Chatbot service Oct 22, 2024
@mabulgu mabulgu marked this pull request as ready for review October 22, 2024 19:21
@mabulgu
Copy link
Author

mabulgu commented Oct 22, 2024

@jameswnl @TamiTakamiya ready for your review. I think we can test the push pipeline once we merge this. It is more or less the same with the PR pipeline, just the image tagging changes so that should work as well.

Link to the successfully run PR pipeline: https://console.redhat.com/application-pipeline/workspaces/ansible-lightspeed/applications/ansible-chatbot-service/pipelineruns/ansible-chatbot-service-on-pr-4-l2f7p

Copy link

@jameswnl jameswnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way I use Konflux is that, the PR will be created by Konflux when a Konflux component is created in the Konflux UI. Like this one

I am not sure if this way would work or not. But anyway, I'll LGTM this.

@mabulgu
Copy link
Author

mabulgu commented Oct 22, 2024

The way I use Konflux is that, the PR will be created by Konflux when a Konflux component is created in the Konflux UI. Like this one

I am not sure if this way would work or not. But anyway, I'll LGTM this.

Hmm Konflux should not mandate where you start the conponent either via code or app but my bad that I did not understand what you say from scratch as I did lots of tekton stuff before and all via YAML.

Lets see how it goes and see if Konflux likes this or not (it is for sure that Tekton part is handled as we have a running pipeline but appwise I will see. In case of any problem I can save these two and create the components PRs and then replace them with my own YAML, but I hope we dont need these.

Thanks for your help so far @jameswnl !

@mabulgu mabulgu merged commit b41893d into main Oct 23, 2024
18 checks passed
@jameswnl jameswnl deleted the story/AAP-32490 branch October 31, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants