Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.rst with base image OS info #693

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Update index.rst with base image OS info #693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ execution environment. You can specify these items:
Choosing a base image
---------------------

You can use any base image you choose.
You can use any base image you choose, as long as it's a RHEL-type image like CentOS, Fedora, or RHEL. These operating systems are directly supported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this reads slightly better.

Suggested change
You can use any base image you choose, as long as it's a RHEL-type image like CentOS, Fedora, or RHEL. These operating systems are directly supported.
The base image must be a RHEL image or one of the RHEL-based variants (CentOS, Fedora, etc.). Other distributions are not supported at this time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't say "RHEL-based variants", since CentOS and Fedora are not based on RHEL (as Ubuntu is based on Debian). Maybe say something like "... or one of the similar distributions (CentOS, ..."?

The smaller the base image, generally, the smaller the final image.
However, to make Ansible Builder more efficient, you should know what packages, if any, are already installed on the base image you use.

Expand Down
Loading