AAP-26663-edits updated section 2.3.3 #1626
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emurtoug
added
Ready for review
emurtoug
commented
Jul 24, 2024
There was a problem hiding this comment.
Line 11:
jamesmarshall24 last week
for "controllers, hubs, and EDA controllers" I would recommend checking with branding to get the name/shortname of each of these and probably parameterize them similar to PlatformName/PlatformNameShort. Maybe something to do in another PR?
Comment copied from PR 812: https://github.com/ansible/aap-docs/pull/812/files#r1682936810
emurtoug
commented
Jul 24, 2024
There was a problem hiding this comment.
Lines 42-49:
jce-redhat 2 days ago
did this procedure go through technical QA? it worked on a test system i built, but formal QA would be better.
Comment copied from PR 812: https://github.com/ansible/aap-docs/pull/812/files#r1686910466
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AAP-26663
Edited the following module for Chapter 2.3.3 of Red Hat Ansible Automation Platform Hardening Guide v2.5: Applying defensive security controls
Updated file:
modules/aap-hardening/ref-apply-defensive-security-controls.adoc