Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only applies to Azure #34

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Only applies to Azure #34

merged 1 commit into from
Mar 25, 2024

Conversation

mfortin
Copy link
Contributor

@mfortin mfortin commented Mar 24, 2024

Overall Review of Changes:
Alternate ordering of section 01 controls only applies to Azure, this cloud detection only checks for Azure Virtual Machines right now.

Issue Fixes:
#33

Enhancements:
None

How has this been tested?:
I tested from the repo/branch from this PR

Results:

TASK [Windows-2022-CIS : 1.2.2 | PATCH | Ensure Account lockout threshold is set to 5 or fewer invalid logon attempt(s), but not 0. | Set Variable.] ***
changed: [10.0.0.3]

TASK [Windows-2022-CIS : 1.2.3 | PATCH | Ensure Allow Administrator account lockout is set to Enabled] ***
changed: [10.0.0.3]

TASK [Windows-2022-CIS : 1.2.4 | PATCH | Ensure Reset account lockout counter after is set to 15 or more minutes. | Set Variable.] ***
changed: [10.0.0.3]

TASK [Windows-2022-CIS : 1.2.1 | PATCH | Ensure Account lockout duration is set to 15 or more minutes. | Set Variable] ***
changed: [10.0.0.3]

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.

@georgenalen
Copy link
Contributor

Hey @mfortin,
Thanks for the PR. It looks good but for one thing. We require commits to have the signed off by along with the GPG signature (which you have). If you would be able to add the signed-off-by flag that would allow us to merge this one in. If need more details on that it's the -s option when committing. If you have additional questions let me know.

Signed-off-by: Mathieu Fortin <[email protected]>
@mfortin mfortin force-pushed the devel branch 2 times, most recently from 970814e to 71641d3 Compare March 25, 2024 14:36
Copy link
Contributor

@MrSteve81 MrSteve81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved Great find and quick and easy fix.

@MrSteve81 MrSteve81 self-requested a review March 25, 2024 15:38
Copy link
Contributor

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MrSteve81 MrSteve81 merged commit 25b45a0 into ansible-lockdown:devel Mar 25, 2024
3 checks passed
@frederickw082922
Copy link
Contributor

Thank you @mfortin !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants