Respect ipv6_disable mechanism #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.
|
hi @joshavant Congratulations on your first PR this is a super catch and happy to accept this PR. Although i have noted that the commit is not signed off by or gpg signed. Unfortunatley both signing types are required before we are able to merge this PR. Many thanks uk-bolly |
joshavant
force-pushed
the
respect-ipv6_disable-mechanism
branch
from
56b2594 to
1d2fdb6
Compare
Signed-off-by: joshavant <[email protected]>
joshavant
force-pushed
the
respect-ipv6_disable-mechanism
branch
from
1d2fdb6 to
504eb15
Compare
|
@uk-bolly Ok, signed off and GPG signed 👍 |
uk-bolly
approved these changes
Jan 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
This adds
when: ubtu22cis_ipv6_disable == 'sysctl'to controls 3.2.2, 3.3.1, 3.3.2.Issue Fixes:
#190
Enhancements:
N/A
How has this been tested?:
develsysctl -preturns exit code of 255sysctl -preturns exit code of 0