Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

found cron regex typo #149

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

dderemiah
Copy link
Contributor

Overall Review of Changes:
Found a typo in cron entry in rsyslog conf
Issue Fixes:
fixes typo and makes CIS compliant

Enhancements:
n/a
How has this been tested?:
Tested locally

Copy link
Member

@uk-bolly uk-bolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch on the '-' but the '#' need to stay that its looking for either starts with cron or #cron allowing the line to be amended.

@dderemiah
Copy link
Contributor Author

You are correct. The '#' was missing in the regex. My correction puts it back. I think it is ready to merge

Copy link
Member

@uk-bolly uk-bolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work

@uk-bolly uk-bolly merged commit aacf253 into ansible-lockdown:devel Oct 30, 2023
3 checks passed
@dderemiah dderemiah deleted the typo_4.2.2.x branch October 31, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants