Siemens/feat/rule 1.6.1.3 enforce vs complain #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernd Grobauer <[email protected]>
… of rules 1.6.1.4 and 1.6.1.3 in the task file. This is necessary because the two rules set the same value, but if both rules are selected, e.g., when using tags for Level 1 and Level 2 (as is necessary when aiming for L2 compliance), then rule 1.6.1.4 must take precedence. Signed-off-by: Bernd Grobauer <[email protected]>
Signed-off-by: Bernd Grobauer <[email protected]>
…his could be removed once the audit role is updated. Signed-off-by: Bernd Grobauer <[email protected]>
Signed-off-by: Bernd Grobauer <[email protected]>
Signed-off-by: Bernd Grobauer <[email protected]>
uk-bolly
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
Control 1.6.1.3 mandates to
Ensure all AppArmor Profiles are in enforce or complain mode.However, the corresponding task only allows the role to set every profile to
enforcemode --the existing toggle in
defaults/main.ymldisables the tasks rather than switching betweenenforceandcomplainmode.Issue Fixes:
#93
Enhancements:
n/a
How has this been tested?:
Tested locally.