Use ansible_facts to reference facts #132
Conversation
jovial
force-pushed
the
feature/inject_facts_as_vars
branch
from
59762dd to
f48cec5
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.
jovial
force-pushed
the
feature/inject_facts_as_vars
branch
from
f48cec5 to
790eecb
Compare
jovial
changed the title
By default, Ansible injects a variable for every fact, prefixed with ansible_. This can result in a large number of variables for each host, which at scale can incur a performance penalty. Ansible provides a configuration option [0] that can be set to False to prevent this injection of facts. In this case, facts should be referenced via ansible_facts.. This change updates all references to Ansible facts from using individual fact variables to using the items in the ansible_facts dictionary. This allows users to disable fact variable injection in their Ansible configuration, which may provide some performance improvement. [0] https://docs.ansible.com/ansible/latest/reference_appendices/config.html#inject-facts-as-vars Signed-off-by: Will Szumski <[email protected]>
jovial
force-pushed
the
feature/inject_facts_as_vars
branch
from
790eecb to
52d62f5
Compare
|
Equivalent to: ansible-lockdown/RHEL9-CIS#54 |
|
hi @jovial Thank you for taking the time to raise this PR and helping to improve ansible-lockdown. It does really help us to improve with feedback. Thank you uk-bolly |
Signed-off-by: Mark Bolwell <[email protected]>
|
hi @jovial Thank you again for you time, I have incorporated your changes into the community_work_fix branch with credits given as i need to try and get these fixes added as quickly as possible. many thanks uk-bolly |
|
hi @jovial Thanks again for taking the time to raise this PR. As mentioned we have managed to incorporate this into many other changes. With credit being given. many thanks once again uk-bolly |
|
Sorry, missed you comments. Thanks @uk-bolly - very much appreciated :) |
Overall Review of Changes:
By default, Ansible injects a variable for every fact, prefixed with
ansible_. This can result in a large number of variables for each host,
which at scale can incur a performance penalty. Ansible provides a
configuration option [0] that can be set to False to prevent this
injection of facts. In this case, facts should be referenced via
ansible_facts..
This change updates all references to Ansible facts from using
individual fact variables to using the items in the
ansible_facts dictionary. This allows users to disable fact variable
injection in their Ansible configuration, which may provide some
performance improvement.
[0] https://docs.ansible.com/ansible/latest/reference_appendices/config.html#inject-facts-as-vars
Issue Fixes:
No issue, but let me know if you want me to create one.
Enhancements:
How has this been tested?:
Ran the role against a host.