Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes regex catching the trailing quote #128

Closed
wants to merge 1 commit into from

Conversation

dderemiah
Copy link
Contributor

Overall Review of Changes:
Change the regex to not match special characters

Issue Fixes:
Replaced /S with /w to catch alphanumeric but not quote at EOL

Enhancements:
n/a
How has this been tested?:
tested locally

@uk-bolly uk-bolly self-assigned this Oct 9, 2023
uk-bolly added a commit that referenced this pull request Oct 9, 2023
@uk-bolly
Copy link
Member

uk-bolly commented Oct 9, 2023

hi @dderemiah

Thank you again for raising this issue, As you may have seen there was an update to ansible-galaxy that had to be resolved to fix the pipeline testing.
We have applied a work around but rerunning workflows still use original settings.
I have taken the base of your excellent submission and extended further allowing a greater area of capture, i have raised a new branch for this work issues_and_collections.
If you could please try this and see if it resolves your issue.

Many thanks

uk-bolly

@dderemiah
Copy link
Contributor Author

Looks good

@uk-bolly uk-bolly mentioned this pull request Oct 10, 2023
@dderemiah dderemiah closed this Oct 12, 2023
@dderemiah dderemiah deleted the fix_1.6.1.2 branch October 12, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants