🐛 Correct default value for ubtu22cis_grub_file: /boot/grub/grub.cfg
#117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CIS's assessment for rule 1.4.2 Ensure permissions on bootloader config are configured uses `/boot/grub/grub.cfg`. I think the current value defined within the variable ubtu22cis_grub_file(respectively /etc/default/grub.cfg) is wrong, as it is a mix between: DEFAULT FILE: /etc/default/grub THE AUTO-GENERATED GRUB FILE: /boot/grub/grub.cfg So the current value `/boot/grub/grub.cfg` is a non-existant file, but CIS rule means `/boot/grub/grub.cfg`. Signed-off-by: Fabian Raab <[email protected]>
raabf
force-pushed
the
siemens/feat/r1_4_2_ubtu22cis_grub_file
branch
from
f2d446a to
81221ae
Compare
|
Ah, you are correct! Then I have overseen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
CIS's assessment for rule 1.4.2 Ensure permissions on bootloader config are configured uses wrong
/boot/grub/grub.cfg.Issue Fixes:
N/A
Enhancements:
I think the current value defined within the variable ubtu22cis_grub_file(respectively /etc/default/grub.cfg) is wrong, as it is a mix between:
DEFAULT FILE: /etc/default/grub
THE AUTO-GENERATED GRUB FILE: /boot/grub/grub.cfg
So the current value
/boot/grub/grub.cfgis a non-existant file, but CIS rule means/boot/grub/grub.cfg.Thanks to @ipruteanu-sie for finding the issue ;-)
How has this been tested?:
Executing the task, look at the result, and CIS-CAT Scanner succeeds.