Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues and workflow updates #19

Merged
merged 21 commits into from
Jul 12, 2024
Merged

Issues and workflow updates #19

merged 21 commits into from
Jul 12, 2024

Conversation

uk-bolly
Copy link
Member

@uk-bolly uk-bolly commented Jul 9, 2024

Overall Review of Changes:
Addition of changelog
update to audit output
update to workflows
removal of dependency on jmespath

Issue Fixes:
some items from #13 thanks to @PoundsOfFlesh
#17 thanks to @knbrende

Enhancements:
Audit
workflows

How has this been tested?:
Manually

uk-bolly added 13 commits July 9, 2024 13:19
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly uk-bolly requested a review from georgenalen July 9, 2024 16:08
uk-bolly added 8 commits July 11, 2024 08:12
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Copy link
Member Author

Pipeline will fail as a task requires skipping as requires a password change, this is fixed for new pipeline

Copy link

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@uk-bolly uk-bolly merged commit b04ef01 into devel Jul 12, 2024
4 checks passed
@uk-bolly uk-bolly deleted the issues_and_workflow_updates branch July 12, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants