Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate and templated task tags #297

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Remove duplicate and templated task tags #297

merged 1 commit into from
Sep 17, 2024

Conversation

qwestduck
Copy link
Contributor

Overall Review of Changes:

This PR removes tags from tasks that are either duplicated or templated (via jinja).

Issue Fixes:

#296

How has this been tested?:

  • Manual running of playbook as described in linked issue.
  • Manually verified failure of pre-commit hook prior to addressing the bug.
  • Manually verified success of pre-commit hook after addressing the bug.

uk-bolly
uk-bolly approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@uk-bolly uk-bolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change and thank you for the new rules.

@uk-bolly uk-bolly merged commit 34db62c into ansible-lockdown:devel Sep 17, 2024
4 checks passed
@uk-bolly uk-bolly mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uk-bolly uk-bolly uk-bolly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwestduck @uk-bolly