Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle Linux rhel8stig_bootloader_path and RHEL-08-020030 fix #240

Closed
wants to merge 2 commits into from
Closed

Conversation

BillSkiCO
Copy link
Contributor

@BillSkiCO BillSkiCO commented Dec 1, 2023

Addressing Oracle Linux distribution identification issue #239

Overall Review of Changes:

  • Oracle Linux distribution was being incorrectly identified in the prelim.yml task
  • RHEL-08-020030 related task fails if lock-enabled is already defined in dconf

Issue Fixes:
Resolves #239
Resolves #241

Enhancements:
N/A

How has this been tested?:

  • Ansible 2.16
  • Oracle Linux 8.8
  1. Observed successful variable assignment of rhel8stig_bootloader_path to /boot/efi/EFI/redhat
TASK [ansible-lockdown.RHEL8-STIG : PRELIM | set fact if UEFI boot | Oracle Linux] *******
ok: [localhost] => {"ansible_facts": {"rhel8stig_bootloader_path": "/boot/efi/EFI/redhat", "rhel8stig_legacy_boot": false}, "changed": false}
...
...
...
TASK [ansible-lockdown.RHEL8-STIG : PRELIM | output bootloader and efi state] ************
ok: [localhost] => {
    "msg": [
        "bootloader path set to /boot/efi/EFI/redhat",
        "legacy boot equals False"
    ]
}
  1. Observed successful enforcement of lock-enabled=true if lock-enabled was already implemented in dconf

Addressing Oracle Linux distribution identification issue #239

Signed-off-by: William Golembieski <[email protected]>
Addressing issue #241 #241

Signed-off-by: William Golembieski <[email protected]>
@BillSkiCO BillSkiCO changed the title Update prelim.yml Oracle Linux rhel8stig_bootloader_path and RHEL-08-020030 fix Dec 1, 2023
@uk-bolly
Copy link
Member

hi @BillSkiCO

Thank you for taking the time to write and provide this PR, We are happy to take the change, although we have noted that the pipeline has failed. We have seen that your gpg key has expired so this will also need to be updated and a repushed. This should hopefully resolve the issues or enable us to investigate the pipeline further.
Many thanks

uk-bolly

@uk-bolly uk-bolly self-assigned this Jan 26, 2024
@BillSkiCO BillSkiCO closed this Feb 2, 2024
@BillSkiCO BillSkiCO reopened this Feb 2, 2024
@BillSkiCO BillSkiCO closed this Feb 2, 2024
@BillSkiCO
Copy link
Contributor Author

Closing PR to resign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RHEL-08-020030 failure if control in place already Oracle Linux Distribution not identified correctly
2 participants