-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post-remediation task fix. #76
Post-remediation task fix. #76
Conversation
Signed-off-by: Dimitris Kambouris <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great find thank you, unfortunately the commit made yesterday was not gpg signed in your branch.
It maybe easier to just sync the latest devel and then add your fix to your fork?
Many thanks
uk-bolly
appears autofix enabled on fork - not signing
c668035
to
d604812
Compare
f0939b3
to
5e5ddf3
Compare
Signed-off-by: Dimitris Kambouris <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work
Overall Review of Changes:
Added tag to "run post_remediation audit" task within tasks/main.yml
Issue Fixes:
Please list (using linking) any open issues this PR addresses
N/A
Enhancements:
Please list any enhancements/features that are not open issue tickets
Post remediation now works with "run_audit" tag instead of failing
How has this been tested?:
Please give an overview of how these changes were tested. If they were not please use N/A
Tested against a public EC2 instance running Amazon Linux 2023. All tasks now complete successfully when using "run_audit" tag.