Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-remediation task fix. #76

Merged

Conversation

d-kambouris
Copy link
Contributor

Overall Review of Changes:
Added tag to "run post_remediation audit" task within tasks/main.yml

Issue Fixes:
Please list (using linking) any open issues this PR addresses
N/A
Enhancements:
Please list any enhancements/features that are not open issue tickets
Post remediation now works with "run_audit" tag instead of failing
How has this been tested?:
Please give an overview of how these changes were tested. If they were not please use N/A
Tested against a public EC2 instance running Amazon Linux 2023. All tasks now complete successfully when using "run_audit" tag.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.

@d-kambouris d-kambouris marked this pull request as draft June 3, 2024 06:53
@d-kambouris d-kambouris marked this pull request as ready for review June 3, 2024 07:15
uk-bolly
uk-bolly previously approved these changes Jun 4, 2024
Copy link
Member

@uk-bolly uk-bolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find thank you, unfortunately the commit made yesterday was not gpg signed in your branch.
It maybe easier to just sync the latest devel and then add your fix to your fork?

Many thanks

uk-bolly

@uk-bolly uk-bolly dismissed their stale review June 4, 2024 09:26

Missing GPG signing

uk-bolly
uk-bolly previously approved these changes Jun 4, 2024
@uk-bolly uk-bolly dismissed their stale review June 4, 2024 16:10

appears autofix enabled on fork - not signing

@d-kambouris d-kambouris marked this pull request as draft June 5, 2024 07:19
@d-kambouris d-kambouris marked this pull request as ready for review June 5, 2024 07:22
@d-kambouris d-kambouris force-pushed the fix-run-post-remediation-task branch from c668035 to d604812 Compare June 5, 2024 07:52
@d-kambouris d-kambouris force-pushed the fix-run-post-remediation-task branch from f0939b3 to 5e5ddf3 Compare June 5, 2024 08:03
Signed-off-by: Dimitris Kambouris <[email protected]>
Copy link
Member

@uk-bolly uk-bolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@uk-bolly uk-bolly merged commit 62bf9bf into ansible-lockdown:devel Jun 5, 2024
3 checks passed
@d-kambouris d-kambouris deleted the fix-run-post-remediation-task branch June 5, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants