Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding empty iterator in case auditd_conf_files register is empty o… #60

Closed

Conversation

DianaMariaDDM
Copy link
Contributor

…r undefined.

Overall Review of Changes:
This PR hold the solution for this issue.

Issue Fixes:

Enhancements:
None

How has this been tested?:
Tested locally.

@uk-bolly
Copy link
Member

uk-bolly commented Mar 8, 2024

hi @DianaMariaDDM

Thank you for this PR, not sure why this is currently failing but didn't fail in the pipeline for updtes you have already applied. It seems it is not discover virtualization_type for some reason.
If you wanted can you try this in the tasks/main.yml and see if this works rather than me raising fixing and you having to sync again.

line 45 /tasks/main.yml

ansible_connection == 'docker' or ( ansible_virtualization_type is defined and
        ansible_virtualization_type in ["docker", "lxc", "openvz", "podman", "container"])

Many thanks

uk-bolly

@DianaMariaDDM
Copy link
Contributor Author

DianaMariaDDM commented Mar 11, 2024

I added the fix in a new commit. Unfortunately, now there is another error that appears to be originating from tasks/LE_audit_setup.yml.

@uk-bolly uk-bolly self-assigned this Mar 27, 2024
@uk-bolly uk-bolly mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants