add reset_then_reuse_values support to helm module #802
Conversation
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 32s |
b0z02003
force-pushed
the
helm_reset_then_reuse_values
branch
from
630d747 to
01b422e
Compare
b0z02003
force-pushed
the
helm_reset_then_reuse_values
branch
from
01b422e to
6486e64
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 13s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 51s |
Co-authored-by: Bikouo Aubin <[email protected]>
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 48s |
|
@abikouo Thanks for the suggestions ! I've tried to improve on them to also check for helm version and added the integration tests (that was a big oversight on my part, my bad). |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 14s |
| if reset_then_reuse_values: | ||
| helm_version = module.get_helm_version() | ||
| if LooseVersion(helm_version) < LooseVersion("3.14.0"): | ||
| module.warn("helm support option --reset-then-reuse-values starting release >= 3.14.0") |
There was a problem hiding this comment.
| module.warn("helm support option --reset-then-reuse-values starting release >= 3.14.0") | |
| module.warn( | |
| "helm support option --reset-then-reuse-values starting release >= 3.14.0" | |
| ) |
| if LooseVersion(helm_diff_version) < LooseVersion("3.9.12"): | ||
| module.warn("helm diff support option --reset-then-reuse-values starting release >= 3.9.12") | ||
| elif LooseVersion(helm_version) < LooseVersion("3.14.0"): | ||
| module.warn("helm support option --reset-then-reuse-values starting release >= 3.14.0") |
There was a problem hiding this comment.
| module.warn("helm support option --reset-then-reuse-values starting release >= 3.14.0") | |
| module.warn( | |
| "helm support option --reset-then-reuse-values starting release >= 3.14.0" | |
| ) |
| helm_diff_version = get_plugin_version("diff") | ||
| helm_version = module.get_helm_version() | ||
| if LooseVersion(helm_diff_version) < LooseVersion("3.9.12"): | ||
| module.warn("helm diff support option --reset-then-reuse-values starting release >= 3.9.12") |
There was a problem hiding this comment.
| module.warn("helm diff support option --reset-then-reuse-values starting release >= 3.9.12") | |
| module.warn( | |
| "helm diff support option --reset-then-reuse-values starting release >= 3.9.12" | |
| ) |
SUMMARY
Starting with version 3.14.0, Helm supports
--reset-then-reuse-values. As discussed on the original PR. This greatly improves on--reuse-valuesas it allows to avoid templates errors when new features are added to an upgraded chart.Closes #803
ISSUE TYPE
COMPONENT NAME
helm
ADDITIONAL INFORMATION
This PR is greatly 'inspired' by #575 and because I wasn't sure how I could provide additional tests for it, I actually copied those build previously for
--reuse-values(as it is an improvement on this feature.