Skip to content

Commit

Permalink
build: don't include v prefix in version tags (#349)
Browse files Browse the repository at this point in the history
##### SUMMARY

The version tag regex allowing to publish to ansible-galaxy does not
allow versions to be prefixed with a v:

https://github.com/ansible/zuul-config/blob/468493fef435a6152d982fc7c41fe2ff2066e139/zuul.d/pipelines.yaml#L146-L155

Introducing the v prefix is also breaking with the previous tag naming
convention.
  • Loading branch information
jooola authored Oct 6, 2023
1 parent e692b3e commit 7f4e4e9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
1 change: 1 addition & 0 deletions .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
token: ${{ secrets.HCLOUD_BOT_TOKEN }}
release-type: simple
package-name: hetzner.hcloud
include-v-in-tag: false

# We use antsibull-changelog for the actual user-facing changelog.
changelog-path: changelogs/dev-changelog.md
Expand Down
5 changes: 2 additions & 3 deletions changelogs/dev-changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@

## [2.1.2](https://github.com/ansible-collections/hetzner.hcloud/compare/2.1.1...v2.1.2) (2023-10-05)


### Bug Fixes

* firewall port argument is required with udp or tcp ([#345](https://github.com/ansible-collections/hetzner.hcloud/issues/345)) ([76c1abf](https://github.com/ansible-collections/hetzner.hcloud/commit/76c1abf44764778aa6e11bae57df5ee5f69a947b))
* invalid field in load_balancer_service health_check.http return data ([#333](https://github.com/ansible-collections/hetzner.hcloud/issues/333)) ([fb35516](https://github.com/ansible-collections/hetzner.hcloud/commit/fb35516e7609fad4dd3fa75138dbc603f83d9aa0))
- firewall port argument is required with udp or tcp ([#345](https://github.com/ansible-collections/hetzner.hcloud/issues/345)) ([76c1abf](https://github.com/ansible-collections/hetzner.hcloud/commit/76c1abf44764778aa6e11bae57df5ee5f69a947b))
- invalid field in load_balancer_service health_check.http return data ([#333](https://github.com/ansible-collections/hetzner.hcloud/issues/333)) ([fb35516](https://github.com/ansible-collections/hetzner.hcloud/commit/fb35516e7609fad4dd3fa75138dbc603f83d9aa0))

## Dev Changelog

Expand Down

0 comments on commit 7f4e4e9

Please sign in to comment.