Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes and features for the pg_hba module #778

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

toydarian
Copy link
Collaborator

SUMMARY
  • Adding myself to the CODEOWNERS file for the parts related to postgresql_pg_hba
  • Deprecates keep_comments_at_rules as discussed in The keep_comments_at_rules option of postgresql_pg_hba breaks idempotency #776
  • Adds parameter sort_rules that allows to disable sorting of rules. The default is true to keep to previous behavior
  • Allows a file to contain include directives and will keep them at the end of the file. Does not allow to add such directives
  • Adds the rendered string that is written to the file as an output

Fixes #776
Fixes #777

ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME

postgresql_pg_hba

ADDITIONAL INFORMATION
  • Removes the old PgHba class and moves the code to different stand-alone methods
  • Uses proper atomic writes
  • Adds tests for several edge-cases and new features
  • The only modification in the tests is to account for the changes regarding keep_comments_at_rules

@Andersson007
Copy link
Collaborator

@toydarian thanks for a lot of good changes! Could you please split the PR into one per changelog entry?

@toydarian
Copy link
Collaborator Author

I can try. It's actually hard, as a lot of the changes are closely tied in together and I want to avoid writing code that will be removed in the next PR.

@Andersson007
Copy link
Collaborator

I can try. It's actually hard, as a lot of the changes are closely tied in together and I want to avoid writing code that will be removed in the next PR.

sure, any smaller PRs would be much appreciated, thanks

@toydarian toydarian marked this pull request as draft December 5, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants