Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql_user: deprecate alias user for name argument #670

Merged

Conversation

Andersson007
Copy link
Collaborator

SUMMARY

Relates to #669.
It wasn't even documented, the failures are addressed in #668

@Andersson007
Copy link
Collaborator Author

ready for review

@Andersson007
Copy link
Collaborator Author

if we wanna merge this, #668 should go first, then I'll rebase it

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.50%. Comparing base (37a718c) to head (89b9b56).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #670      +/-   ##
==========================================
+ Coverage   76.31%   76.50%   +0.19%     
==========================================
  Files          20       20              
  Lines        2651     2652       +1     
  Branches      676      676              
==========================================
+ Hits         2023     2029       +6     
+ Misses        427      422       -5     
  Partials      201      201              
Flag Coverage Δ
integration 75.86% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andersson007
Copy link
Collaborator Author

ready for review

@samccann
Copy link
Contributor

Not really qualified for an official review, but the changes make sense to me.

@laurent-indermuehle
Copy link
Collaborator

I'm not super fan of removing an alias afterward.
But I parsed all my code base and it turns out, I only use 'name'. Not surprised because it's the default for Ansible modules after all.

So for simplification sake, let's merge this! :)
Thanks @Andersson007 for the work!

@laurent-indermuehle laurent-indermuehle merged commit 59c2621 into ansible-collections:main Sep 2, 2024
49 checks passed
@Andersson007
Copy link
Collaborator Author

@samccann @laurent-indermuehle thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants