Builds on HCI inventory and adds ARC support as well #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p3ck
added
inventory
p3ck
force-pushed
the
hci_vms_inventory
branch
3 times, most recently
from
4fb6293
to
39dc14a
Compare
Fred-sun
reviewed
Oct 17, 2024
TiTi
reviewed
Oct 17, 2024
TiTi
reviewed
Oct 17, 2024
p3ck
force-pushed
the
hci_vms_inventory
branch
from
39dc14a
to
4521348
Compare
By default ARC hosts will not show up in inventory, but you can use the
following inventory config to get them.
plugin: azure.azcollection.azure_rm
include_arc_resource_groups: ['*']
Use hostvar_expressions to modify the default ansible ssh config
hostvar_expressions:
ansible_host: "resource_group + '-' + name if 'Microsoft.HybridCompute/machines' == resource_type else (public_dns_hostnames + public_ipv4_address) | first"
ansible_ssh_common_args: "'-F /tmp/' + resource_group + '-' + name + '/ssh_config' if 'Microsoft.HybridCompute/machines' == resource_type"
Use keyed_groups to organize them or tags
keyed_groups:
- prefix: "type"
key: resource_type
trailing_separator: false
Use the azure_rm_arcssh action plugin to configure the dynamic inventory
hosts with ssh proxy settings:
- name: Configure ARC SSH Proxy
hosts: localhost
connection: local
tasks:
- name: Setup Proxy
azure.azcollection.azure_rm_arcssh:
inventory_hostname: "{{ item }}"
ansible_host: "{{ hostvars[item].ansible_host }}"
local_user: admin
resource_group: "{{ hostvars[item].resource_group }}"
resource_type: "{{ hostvars[item].resource_type }}"
private_key_file: "~/.ssh/id_rsa"
ssh_config_file: "/tmp/{{ hostvars[item].resource_group }}-{{ item }}/ssh_config"
ssh_relay_file: "/tmp/{{ hostvars[item].resource_group }}-{{ item }}/relay_info"
ssh_proxy_folder: "~/.clientsshproxy"
loop: "{{ groups['type_Microsoft_HybridCompute_machines'] }}"
- name: Ping ARC Hosts
hosts: type_Microsoft_HybridCompute_machines
tasks:
- name: Ping
ansible.builtin.ping:
p3ck
force-pushed
the
hci_vms_inventory
branch
from
4521348
to
aeeee10
Compare
TiTi
reviewed
Oct 23, 2024
plugins/inventory/azure_rm.py
Outdated
| for ipaddr in nic.get('ipAddresses', []): | ||
| ipAddressVersion = ipaddr.get('ipAddressVersion') | ||
| if ipAddressVersion == 'IPv4': | ||
| new_hostvars['ansible_all_ipv4_addresses'].append(ipaddr.get('address')) |
There was a problem hiding this comment.
also fill private_ipv4_addresses ?
There was a problem hiding this comment.
Can we assume all IPv4 addresses are private?
There was a problem hiding this comment.
I included the netaddr package and use is_global() to determine
|
remark, if I do: I notice that it gives me the arc objects, but also the stack hci vms (because they are arc objects). We currently have no way to only list arc objects which are non-stack hci vms. I'm not saying this needs to be fixed, this is just a remark. |
|
@Fred-sun Can you review? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds support for listing ARC machines in inventory.
ISSUE TYPE
COMPONENT NAME
plugins/action/azure_rm_arcssh.py
plugins/doc_fragments/azure_rm.py
plugins/inventory/azure_rm.py
plugins/modules/azure_rm_arcssh.py
plugins/plugin_utils/connectivity_utils.py
plugins/plugin_utils/constants.py
plugins/plugin_utils/file_utils.py
plugins/plugin_utils/ssh_info.py
requirements.txt
ADDITIONAL INFORMATION
SSH proxy setup is done via an action plugin. This provides the most flexibility for the user to configure the hosts the way they need to. They can group hosts based on tags and have different ssh permissions or keys depending on the group.