-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new module azure_rm_afdroute to support Azure Frontdoor Standard and Premium #1595
base: dev
Are you sure you want to change the base?
Conversation
yaml[indentation]: Wrong indentation: expected 6 but found 8 yaml[indentation]: Wrong indentation: expected 10 but found 12 yaml[indentation]: Wrong indentation: expected 10 but found 12 yaml[indentation]: Wrong indentation: expected 10 but found 12 yaml[trailing-spaces]: Trailing spaces yaml[trailing-spaces]: Trailing spaces yaml[trailing-spaces]: Trailing spaces yaml[trailing-spaces]: Trailing spaces yaml[empty-lines]: Too many blank lines (1 > 0) |
Submitted this issue due to the inability to pass a NULL for clearing the cache_configuration. Azure/azure-sdk-for-python#35801 Will need to test and adjust this code to ensure fully functioning. This may require the azure-mgmt-cdn module to then get bumped to 13.1.1, not 13.1.0 as previously thought and submitted in #1588 Planning to test and cycle back next week. |
Which Sanity check, if one exists, is catching these? Would love to capture this before i submit...thanks! |
@jartoo You can check sanity by referring to the following connection methods, change to the installation directory!. Thanks!
|
@jartoo You can also install ansible-lint to check the ansible-playbooks format specification! Thanks! |
@jartoo can you help resolve the file conflict. |
test failed:
|
@jartoo There is a conflict in this PR, please help solve the conflict, thank you! |
SUMMARY
This module manages Frontdoor Routes for the Standard and Premium services. I propose building this as a separate module in lieu of complicating the azure_cdn_profile module so as to make the management of each of the elements easier. Azure Frontdoor is quite complex, so matching the modules with the Python SDK APIs seems to be the prudent design choice.
Continues to work on #1041 This does not complete this issue, yet.
ISSUE TYPE
COMPONENT NAME
Module: azure_rm_afdroute
ADDITIONAL INFORMATION
Provides the ability to manage Routes, per the Python SDK here: https://learn.microsoft.com/en-us/python/api/azure-mgmt-cdn/azure.mgmt.cdn.operations.routesoperations?view=azure-python
Integration Tests: passed
Sanity Tests: passed