Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MASP fees #401

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Update MASP fees #401

merged 3 commits into from
Nov 14, 2024

Conversation

grarco
Copy link
Contributor

@grarco grarco commented Nov 11, 2024

Updates fee docs given anoma/namada#3959:

  • Updated gas costs given the new scale
  • Updated the --gas-spending-key logic
  • Marked --disposable-gas-payer as the recommended solution
  • Added a section about the masp fee payment gas limit and some ways around it

batconjurer
batconjurer reviewed Nov 11, 2024
View reviewed changes
Copy link
Member

@batconjurer batconjurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some changes for readability, typos, and grammar

@batconjurer batconjurer self-requested a review November 12, 2024 09:02
brentstone
brentstone approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@brentstone brentstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx so much

@brentstone brentstone merged commit 5469155 into master Nov 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentstone brentstone brentstone approved these changes

@batconjurer batconjurer batconjurer approved these changes

@sug0 sug0 Awaiting requested review from sug0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grarco @batconjurer @brentstone