Added ProviderId for LocalProvider & Added optional support for alternative id format #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request add ExternalId for episode, music video and movies when using the local provider. Right now the local provider only add ExternalId for series which i assume is unattended because the remote provider does add the ExternalId for the mentioned objects.
This pull request also contains regex updates to support alternative id format like
[youtube-(id)]. This format is optional and the original format of[(id)]works as expected.Forgive my coding style changes as this is the first time working with C# codebase and i used the defaults that comes with vscode.