Fixed tests

ankane · Sep 3, 2024 · d5f0301 · d5f0301
1 parent f571a36
commit d5f0301
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/test/knn_test.rb b/test/knn_test.rb
@@ -4,7 +4,10 @@ class KnnTest < Minitest::Test
   def test_works
     store [{name: "A", embedding: [1, 2, 3]}, {name: "B", embedding: [-1, -2, -3]}]
     assert_order "*", ["A", "B"], knn: {embedding: [1, 2, 3]}
+
     expected = Searchkick.opensearch? ? [1, 0] : [2, 1]
-    assert_equal expected, Product.search(knn: {embedding: [1, 2, 3]}).hits.map { |v| v["_score"] }
+    scores = Product.search(knn: {embedding: [1, 2, 3]}).hits.map { |v| v["_score"] }
+    assert_in_delta expected[0], scores[0]
+    assert_in_delta expected[1], scores[1]
   end
 end
diff --git a/test/models/product.rb b/test/models/product.rb
@@ -23,12 +23,6 @@ class Product
     match: ENV["MATCH"] ? ENV["MATCH"].to_sym : nil,
     knn: {embedding: {dimensions: 3}}
 
-  if ActiveRecord::VERSION::STRING.to_f >= 7.1
-    serialize :embedding, coder: JSON
-  else
-    serialize :embedding, JSON
-  end
-
   attr_accessor :conversions, :user_ids, :aisle, :details
 
   class << self

diff --git a/test/support/activerecord.rb b/test/support/activerecord.rb
@@ -76,6 +76,12 @@
 
 class Product < ActiveRecord::Base
   belongs_to :store
+
+  if ActiveRecord::VERSION::STRING.to_f >= 7.1
+    serialize :embedding, coder: JSON
+  else
+    serialize :embedding, JSON
+  end
 end
 
 class Store < ActiveRecord::Base

diff --git a/test/support/mongoid.rb b/test/support/mongoid.rb
@@ -21,6 +21,7 @@ class Product
   field :longitude, type: BigDecimal
   field :description
   field :alt_description
+  field :embedding, type: Array
 end
 
 class Store