Don't search misspellings for an errored query (#1655)

ankane · Nov 22, 2023 · a4cbb61 · a4cbb61
1 parent a682677
commit a4cbb61
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/searchkick/query.rb b/lib/searchkick/query.rb
@@ -191,7 +191,7 @@ def handle_response(response)
     end
 
     def retry_misspellings?(response)
-      @misspellings_below && Results.new(searchkick_klass, response).total_count < @misspellings_below
+      @misspellings_below && response["error"].nil? && Results.new(searchkick_klass, response).total_count < @misspellings_below
     end
 
     private

diff --git a/test/multi_search_test.rb b/test/multi_search_test.rb
@@ -33,6 +33,12 @@ def test_misspellings_below_unmet
     assert_equal ["abc", "abd"], products.map(&:name)
   end
 
+  def test_misspellings_below_with_errored_query
+    products = Product.search("abc", order: [:bad_field], misspellings: {below: 1})
+    Searchkick.multi_search([products])
+    assert products.error
+  end
+
   def test_query_error
     products = Product.search("*", order: {bad_column: :asc})
     Searchkick.multi_search([products])