Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

Added couple of images of the app #380

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

AjayThakur12
Copy link
Contributor

Description

Added PowerUp app images

Fixes #368

Type of Change:

  • Documentation

Code/Quality Assurance Only

  • This change requires a documentation update (software upgrade on readme file)

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

@anubhavpulkit
Copy link
Contributor

anubhavpulkit commented Mar 10, 2020

@AjayThakur12 I think you can't update your remote copy. Start page and Avatar view are modified and if you change the orientation of all images to landscape mode then it looks more beautiful.

@sunjunkie
Copy link
Contributor

@AjayThakur12

  • The images are not from the latest repo. You will have to update them.
  • As mentioned above, please show the images in landscape mode because that's the way they are viewed in the app.
  • 2 images is enough. The readme is not a tutorial of the game. Pick a maximum of 2 screens - maybe the map screen and a mini game screen (not a tutorial screen). Be sure to create captions for the screens.

@AjayThakur12
Copy link
Contributor Author

@sunjunkie okay I will do recommended changes

@sunjunkie
Copy link
Contributor

@AjayThakur12 Are you planning to update this PR per the recommended changes?

@AjayThakur12
Copy link
Contributor Author

@sunjunkie sorry for the delay. I will update by today

@sunjunkie sunjunkie self-requested a review April 15, 2020 04:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add couple of images of the app to the README
3 participants