-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Create About.jsx #100
Conversation
Create About.jsx for About section Add route in Routes.js Move Home.jsx to home folder Fixes anitab-org#96
Hello there!👋 Welcome to the project!💖 Thank you and congrats🎉 for opening your first pull request.✨ AnitaB.org is an inclusive community, committed to creating a safe and positive environment.🌸Please adhere to our Code of Conduct and Contribution Guidelines.🙌.We will get back to you as soon as we can.😄 Feel free to join us on AnitaB.org Open Source Zulip Community.💖 We have different streams for each active repository for discussions.✨ Hope you have a great time there!😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HeroicHitesh , I can't see the image being displayed when I run the app. It looks like you need to add the image file locally inside the home
folder and refer to it as the src
address.
Actually..... it's now visible (after waiting for a while). I wonder if it's better to add image to folder or use online refence 🤔
Perhaps we can keep it as it is for now, and only change it later when it becomes an issue.
Other than that, this PR looks good 👍 and I noticed that you've made the navbar looks prettier
, which is awesome ✨✨.
But I'd like to ask you to change one thing. It's not a fault from your side, I just have a change of mind with the url link to Read more about the projeect here...
. Initially I put the BridgeInTech repo as link since I'm thinking as a developer. But our user might not be interested on contributing to BridgeInTech project as developer, instead they want to use BridgeInTech as a user (organization/mentor/mentee). In this situation, an intro to what the application is about and benefit seems to be more useful for our user.
For that purpose, can you please change the link to https://medium.com/anitab-org-open-source/bridgeintech-by-anitab-org-85745853865d?source=friends_link&sk=fcb616ef0ac7e1e85ac6b58b513a56ee
instead? This is my medium blog post for Introduction to BridgeInTech from an application overview.
I really appreciate your help. 👍
Add [Medium article link](https://medium.com/anitab-org-open-source/bridgeintech-by-anitab-org-85745853865d?source=friends_link&sk=fcb616ef0ac7e1e85ac6b58b513a56ee) to `a` tag of `Read more about the project here...`
@mtreacy002 I read this in one of the GitHub repo's PR reviews that it's better to use online reference instead of statically adding content, to reduce the total repository size.
Done👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @HeroicHitesh, just need one more confirmation from you.
Makes sense...
That's also my wish, @HeroicHitesh, for this purpose and also for the purpose of having reliable remote servers .... cc @anitab-org/bridgeintech-maintainers and @anitab-org/bridgeintech-managers 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did a great job, @HeroicHitesh on your First-Timers-Only issue. I'm really happy that you''re contributing to the project 🎉. Look forward to your next contribution 😉
Thank you for the kind words, looking forward to contributing to more |
Don't forget there're many ways you could contribute to the project, as mentioned on zulip post here. Perhaps start a discussion about the design on the #bridge-in-tech stream on the Navbar improvement you mentioned before? 😁 |
True. Actually I am more inclined towards resolving all the React issues, so I mentioned that apart from that I'll surely contribute wherever I can.
I guess you confused me with |
aaa... yes, sorry, got mixed up 😊. Anyway, any kind of participation is welcomed 😉. There are few other available issues here if you're interested. Just ping me if you find one so I can assign you to it 😁 |
I have no idea about testing in React but would love to learn something about it, so can you redirect me to some useful resources for me to get started with contributing to #33
😅Sorry for messaging here, in Zulip PMs are disabled, so I wasn't able to ping you there. |
@HeroicHitesh , on our AnitaB.Org Open Source zulip, the PM is disabled. However, you don't need to use PM at all to ping me. As part of Open Source value, we encourage open communication. So you can ping me (or anyone you want to reach out) on the channel/topic you want to have discussion on. The benefit of pinging using zulip is it's much faster to reach out to member you ping instead of using github. Because zulip app also available on mobile phone and its notification works just like whatsapp or other Mobile Messaging application. |
Congrats on merging your first pull request! 🎉🎉🎉 |
Description
About.jsx
for About section inhome
folder/about
route inRoutes.js
Home.jsx
tohome
folderreact-scripts
dependency from version3.4.1
to^3.4.3
inpackage.json
Fixes #96
Type of Change:
Checklist:
Screenshot of change: