t

angry-goose-initiative · Mar 29, 2024 · 79ea265 · 79ea265
1 parent 9990172
commit 79ea265
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/loaders/loaders.cc b/loaders/loaders.cc
@@ -8,9 +8,10 @@
 #include "loaders.h"
 
 #include <fstream>
+#include <string>
 #include <vector>
 
-agi::loaders::Res agi::loaders::elf_32(std::string_view   file_name,
+agi::loaders::Res agi::loaders::elf_32(std::string   file_name,
                                        BaseWriteFunctor & write_functor)
 {
     std::ifstream file(file_name, std::ios::binary);
@@ -182,7 +183,7 @@ agi::loaders::Res agi::loaders::elf_32(std::string_view   file_name,
 agi::loaders::Res agi::loaders::verilog_32(std::string_view   file_name,
                                            BaseWriteFunctor & write_functor)
 {
-    std::fstream file = std::fstream(file_name);
+    std::fstream file(file_name);
     if (!file) {
         return Res::FILE_OPEN_ERROR;
     }

diff --git a/loaders/loaders.h b/loaders/loaders.h
@@ -10,6 +10,7 @@
 #include <cstddef>
 #include <cstdint>
 #include <span>
+#include <string>
 #include <string_view>
 
 namespace agi::loaders {
@@ -49,7 +50,7 @@ class BufferWriteFunctor : public BaseWriteFunctor {
     size_t             offset_;
 };
 
-Res elf_32(std::string_view file_name, BaseWriteFunctor & write_functor);
+Res elf_32(std::string file_name, BaseWriteFunctor & write_functor);
 
 Res verilog_32(std::string_view file_name, BaseWriteFunctor & write_functor);