-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce exact_match=True
when listing JSON file for get_estimated_time
for MPH
#467
base: main
Are you sure you want to change the base?
Conversation
The current way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, the logic for dropping the extension when checking for an exact match is probably a good idea. We would just need to check ark and toffy to make sure that isn't in there for a specific reason.
I would add a -processing.json
file to all relevant tests in the pipeline, to see if list_files()
breaks anywhere else in toffy.
…itten (not immediately after .bin file written)
…or from popping up
… match "pulse_heights_..."
…d TODO for fixing verify_same_elements edge case
What is the purpose of this PR?
Closes #465. The way
list_files
works is not robust against the new_processing.json
files that get written to the CACs. Forget_estimated_time
, this causes issues when verifying that a FOV exists in the run folder, then loading it in because sometimes it will attempt to verify the_processing.json
file and not the main FOV.json
file.How did you implement your changes
Make use of
exact_match=True
forlist_files
to enforce hard matching.Remaining issues
Across several places in
toffy
andark
,exact_match=True
must be used, especially because Bryan's ezSegmenter update makes soft matching the default.