Add support for Kaminari #2
Conversation
rzane
force-pushed
the
kaminari
branch
2 times, most recently
from
a8f2379 to
bf441c7
Compare
|
Thanks @rzane ! Can you rebase off main? |
| require "tapioca/dsl/compilers/active_record_relations" | ||
| require "tapioca/dsl/helpers/active_record_column_type_helper" |
There was a problem hiding this comment.
Adding these explicit requires allows us to remove the Tapioca shim.
If you add ActiveRecord.eager_load! to the bottom of this file, you could probably get rid of activerecord.rbi.
If you require attr_json here and run tapioca dsl, you can probably get rid of the attr_json shim.
There was a problem hiding this comment.
Thanks! I've had mixed success orchestrating all of these requires in the past with our internal projects, and it's been easier to just cut the shim. But I'll give it a try here!
| require "tapioca/dsl/compilers/active_record_relations" | ||
| require "tapioca/dsl/helpers/active_record_column_type_helper" |
There was a problem hiding this comment.
Thanks! I've had mixed success orchestrating all of these requires in the past with our internal projects, and it's been easier to just cut the shim. But I'll give it a try here!
This PR adds a compiler for Kaminari.