Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract mp3 bitrate from synchronized header #348

Closed
wants to merge 1 commit into from

Conversation

chientrm
Copy link

This helps determining bitrate of the first frame synchronized.

@google-cla
Copy link

google-cla bot commented Apr 21, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@icbaker
Copy link
Collaborator

icbaker commented Apr 21, 2023

As explained in google/ExoPlayer#11124 (comment) we won't accept this into the library, because it assumes all MP3 files are CBR, which is not a valid assumption. Propagating the bitrate in a way that either works for both VBR and CBR, or only affects truly CBR files is much harder as described in that comment.

My suggestion in google/ExoPlayer#11124 (comment) is that if you want to make this assumption you can make (and keep) this change locally.

@icbaker icbaker closed this Apr 21, 2023
@androidx androidx locked and limited conversation to collaborators Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants