Add support for SSA (v4+) MarginL, MarginR, MarginV style #2008
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening google/ExoPlayer#10169.
This PR is about adding support for
MarginL
,MarginR
,MarginV
from both theStyle
andDialogue
lines. I've used VLC as reference.Dialogue
lines takes priority over the margins inStyle
lines.{\pos}
override, then no margins will be applied neither fromDialogue
orStyle
(same as in VLC).{\an}
override, then VLC ignores theDialogue
margin but applies theStyle
margin which makes no sense for me, so in our case I've just ignored bothDialogue
andStyle
margins (same as{\pos}
case).Suggestion: maybe we could update the
https://storage.googleapis.com/exoplayer-test-media-1/ssa/test-subs-position.ass
subtitle file with these new lines, then no need for a new media inmedia.exolist.json
.