Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SSA (v4+) MarginL, MarginR, MarginV style #2008

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

szaboa
Copy link
Contributor

@szaboa szaboa commented Dec 30, 2024

Reopening google/ExoPlayer#10169.

This PR is about adding support for MarginL, MarginR, MarginV from both the Style and Dialogue lines. I've used VLC as reference.

  • Non-zero margins defined in Dialogue lines takes priority over the margins in Style lines.
  • In case we have a {\pos} override, then no margins will be applied neither from Dialogue or Style (same as in VLC).
  • In case we have a {\an} override, then VLC ignores the Dialogue margin but applies the Style margin which makes no sense for me, so in our case I've just ignored both Dialogue and Style margins (same as {\pos} case).

Suggestion: maybe we could update the https://storage.googleapis.com/exoplayer-test-media-1/ssa/test-subs-position.ass subtitle file with these new lines, then no need for a new media in media.exolist.json.

@peerless2012
Copy link

Add ass feature for exoplayer use Java code mabe a huge work。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants