-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add seamless transfer support #393
base: main
Are you sure you want to change the base?
Conversation
common/src/main/java/com/example/android/uamp/media/extensions/MediaMetadataCompatExt.kt
Outdated
Show resolved
Hide resolved
@@ -91,6 +91,10 @@ | |||
</intent-filter> | |||
</service> | |||
|
|||
<receiver | |||
android:exported="true" | |||
android:name="androidx.mediarouter.media.MediaTransferReceiver" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to figure out what seamless transfer is about. I am still not really sure. I haven't found any material what seamless transfer means, exactly. However, this is the problematic line. Adding this to the manifest makes the Cast session not start (or at least not notify us/CastSessionManager of the session start). I suspect by adding this we are overriding a behavior which makes the Cast-MediaRoute-related plumbing.
I have commented on the guidance doc to see if I can get some assistance from the Seoul team on this. I would think they are the ideal people to look into this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After asking around, from Olly who also is in the seamless transfer doc:
For seamless transfer and the part of the Cast SDK that does routing to work together properly, the Cast SDK needs updating. Before the Cast SDK can be updated, the MediaRouter AndroidX library needs updating. So there is a chain of pending things that need to happen.
So it would seem this patch cannot go in until we update the Cast SDK to the right version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for investigating. That seems to be the case.
dd47b03
to
9a237bf
Compare
9b7a9f8
to
3a1eecb
Compare
067c291
to
0c7566a
Compare
This PR adds support for seamless transfer, allowing users to switch audio outputs using the output switcher.