Replace ALooper_pollAll with ALooper_pollOnce.
#1002
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `pollAll` API was removed because it can't be used safely. The recommendation is to replace existing calls to `pollAll` with `pollOnce` with an explicit loop. There are quite a few other samples that are doing this. Fixing one to start so I can check with someone that understands the `pollAll` bug so I don't accidentally copy the same bug, then I'll fix the others. android#999
|
@jreck says this isn't actually a good fix. The problem is present when calling The better fix is to migrate to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pollAllAPI was removed because it can't be used safely. The recommendation is to replace existing calls topollAllwithpollOncewith an explicit loop.There are quite a few other samples that are doing this. Fixing one to start so I can check with someone that understands the
pollAllbug so I don't accidentally copy the same bug, then I'll fix the others.#999