Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modal navigation #106

Merged
merged 9 commits into from
Jan 4, 2025
Merged

feat: modal navigation #106

merged 9 commits into from
Jan 4, 2025

Conversation

andrewbenington
Copy link
Owner

Description

Allows the user to navigate forward/backward in a box when the Pokémon details modal is open. The user can use the displayed arrow buttons or the keyboard's arrow buttons.

Issue

Fixes #102

Images
(Box position display at the bottom is a WIP)
Screenshot 2025-01-03 at 4 55 26 PM

andrewbenington and others added 9 commits January 1, 2025 22:42
* Resource pack backend

* simplified `download_images_from_github_folder`

* Added to `tauriInvoker`

* Added button to `Settings` to download gen1 sprite pack.

* ran linter

* initial plugin downloading/management

* plugin card styling

* fix for missing plugin folder

* async plugin download

* keep home mounted

* housekeeping

* move gen 7 sprites to plugin

* start persisting enabled plugins

* plugin enabled status persists correctly

* move gen 6 sprites to plugin

* newline

* bump version

* standardize icon.png and assets dir

* image url update

* Created delete plugin command

* Set up debugging in VSCode (#97)

* Update launch.json

* Update tasks.json

* Fixed it

* renamed `ui` to `frontend`

* Got rid of problem matcher

* Fixed vscode settings

* fix last opened (recent saves) (#99)

* plugin page tabs

* installed plugin dropdown menu

* fix unused var

* added `deletePlugin` to tauri invoker

* Added `deletePLugin` to backend

* made changes

* implmented deletion of plugin

* ran linter

* Moved code w/i `delete_plugin` to generic `util::delete_folder`.

This is so it can be reused in the future

* Fixed display

* Fixed plugin icon covering chips

* added `deletePlugin` to dummy backend

* delete icon styling

* update plugin metadata fields

* log plugin sprite error instead of displaying

* cleanup plugin state on delete

* coalesce plugin actions

* include version and api_version in downloaded metadata

---------

Co-authored-by: evanwporter <[email protected]>
Co-authored-by: Evan <[email protected]>
* make rust functions more eloquent

* with_icon_bytes consumes self
@andrewbenington andrewbenington marked this pull request as ready for review January 4, 2025 17:58
@andrewbenington andrewbenington merged commit c552cdf into main Jan 4, 2025
3 checks passed
@andrewbenington andrewbenington deleted the modal-navigation branch January 4, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: navigate forwards and backwards in a box from the Pokémon display modal
1 participant