- Optimized all the stubs and docblocks #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maxvrdev
commented
Oct 17, 2021
maxvrdev
commented
- Branched from DEV
- Updated all Stubs & Docblocks
- Branched from DEV
|
Hi, i've marked this PR as draft, cause it doesn't fix issue #32. Issue is related to all stub file (located under All of this file should be checked and, eventually, fixed. Please, remember that you should check files in dev branch, not master, because it is not updated. Furthermore, master should have only stable code, so all the new features must be merged only in dev. Please, add fix to all these file so we can close this feature and thank you very much for your support :) Please remember you have to add all dependencies with |
There was a problem hiding this comment.
Controller.stub
in Controller.stub, update function, please replace in dockblock
\App\Http\Requests\{{modelName}}Request $request
with => {{modelName}}Request $request
Model.stub
There is no sense of use App\Models\{{modelName}};, as model class is self-importing itself. Please remove it
Clean up the imports on the Controller Stub
andreacivita
approved these changes
Oct 20, 2021
andreacivita
added a commit
that referenced
this pull request
Oct 20, 2021
This reverts commit d51e8a5.
|
Fix #32 |
andreacivita
pushed a commit
that referenced
this pull request
Oct 23, 2021
* - Optimized all the stubs and docblocks * Add Import to Model Stub * Remove the import from the Model Stub Clean up the imports on the Controller Stub Related to issue #32 Co-authored-by: [email protected] <[email protected]>
andreacivita
added a commit
that referenced
this pull request
Oct 23, 2021
* Update .travis.yml * Revert "Update .travis.yml" This reverts commit 6c54da4. * Update GeneratorTest.php * feat: Hard Refactor (#29) * Updated stub-test * New Generators * Added dependency Support * Removed unused param & added setData * commands depends on new generators Old generator has been deprecated * Updated PHPUnit test suite * ControllerGenerator + tests * FactoryGenerator + test * ModelGenerator + test * RequestGenerator + test * ResourceGenerator + test * RouteGenerator + tests * fix: typo in ModelGenerator * TestGenerator + test * Stub + test * updated .gitignore * Php-cs-fixer Co-authored-by: Andrea Civita <[email protected]> * Namespace Added to Factory Stub (#33) (#36) Co-authored-by: Max VanRay <[email protected]> * - Optimized all the stubs and docblocks (#35) * - Optimized all the stubs and docblocks * Add Import to Model Stub * Remove the import from the Model Stub Clean up the imports on the Controller Stub Related to issue #32 Co-authored-by: [email protected] <[email protected]> Co-authored-by: Andrea Civita <[email protected]> Co-authored-by: Max VanRay <[email protected]> Co-authored-by: Max VanReynegom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.