Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: Remove upload-artifact@v3 hack. #532

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

rspier
Copy link
Collaborator

@rspier rspier commented May 23, 2024

Act now supports upload-artifact@v4, so we don't need to special case that in testing.

Act now supports upload-artifact@v4, so we don't need to special case that
in testing.
@rspier rspier added the do not merge indicates that this PR should not be merged. label May 25, 2024
@rspier
Copy link
Collaborator Author

rspier commented May 26, 2024

Successfully tested with:

../act/act --artifact-server-path=/tmp/artifacts

act repo is at e1e5671e3d9e (committed May 20).

@rspier rspier requested a review from rjbs May 26, 2024 03:39
@rspier rspier removed the do not merge indicates that this PR should not be merged. label May 26, 2024
Copy link
Collaborator

@rjbs rjbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 Looks good.

@rspier rspier merged commit c75fe70 into andk:master Jun 5, 2024
2 checks passed
@rspier rspier deleted the act4 branch June 5, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants