Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning about spurt #524

Merged
merged 1 commit into from
May 20, 2024
Merged

Fix warning about spurt #524

merged 1 commit into from
May 20, 2024

Conversation

rspier
Copy link
Collaborator

@rspier rspier commented May 19, 2024

Mojo::File::spurt is deprecated in favor of Mojo::File::spew at t/pause_2017/action/add_uri.t line 37.

@rspier rspier requested review from rjbs and charsbar May 19, 2024 05:25
@charsbar
Copy link
Collaborator

This is only acceptable when the version of Mojolicious in the production server is upgraded to the version 9.34 or higher.
cf. https://metacpan.org/dist/Mojolicious/changes#L18 and https://metacpan.org/dist/Mojolicious/changes#L22

@rspier
Copy link
Collaborator Author

rspier commented May 19, 2024

Looks OK to me.

/home/pause/.plenv/shims/perl
pause@pause3:~$ perl -MMojolicious -le'print $Mojolicious::VERSION'
9.36

@rspier
Copy link
Collaborator Author

rspier commented May 19, 2024

@rjbs Do we want to pin all the versions so they line up between test and prod to try and prevent surprises?

@wolfsage
Copy link
Collaborator

@rjbs Do we want to pin all the versions so they line up between test and prod to try and prevent surprises?

IMO yeah, our builds should give us the same setup as prod

@rjbs
Copy link
Collaborator

rjbs commented May 19, 2024

@rspier Yes.

@rspier
Copy link
Collaborator Author

rspier commented May 20, 2024

tracking that in #529

Mojo::File::spurt is deprecated in favor of Mojo::File::spew at t/pause_2017/action/add_uri.t line 37.
@rspier rspier merged commit e15e29e into andk:master May 20, 2024
1 check passed
@rspier rspier deleted the spew branch May 20, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants