Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: quiet noise from verbosely run tests #511

Merged
merged 2 commits into from
May 11, 2024
Merged

tests: quiet noise from verbosely run tests #511

merged 2 commits into from
May 11, 2024

Conversation

rjbs
Copy link
Collaborator

@rjbs rjbs commented May 11, 2024

This really only affects the indexer tests but:

  1. do not print "initializing git repo" for every single new TestPAUSE
  2. when printing out whether files changed, replace the long tmpdir path with ${TEST} to reduce clutter

(The path will be gone, so seeing it isn't useful. If you need to work with the results, you can call $testpause->run_shell in the tests.)

rjbs added 2 commits May 11, 2024 13:13
@rjbs
tests: initialize test git repo with --quiet
6e37f75 
This is around 10% of the lines in some tests, and worthless.
@rjbs
tests: print ${TEST} instead of tmpdir path in output
e5587d3 
The tmpdir will have been pruned, so printing the fill path is not
useful.  Also, it is a pain to read and makes for very long lines.

Just show when files are relative to the TestPAUSE tmpdir.
@rjbs rjbs requested a review from rspier May 11, 2024 17:16
@rjbs rjbs merged commit caafc03 into andk:master May 11, 2024
1 check passed
@rjbs rjbs deleted the quiet-test-noise branch May 12, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rspier rspier rspier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjbs @rspier