Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect class/role if the PAUSE finds a few modules are used in the pacakge file #447

Closed
wants to merge 5 commits into from
Closed

Respect class/role if the PAUSE finds a few modules are used in the pacakge file #447

wants to merge 5 commits into from

Conversation

charsbar
Copy link
Collaborator

Fixes #390 and #436.

@rjbs rjbs self-requested a review April 25, 2024 18:00
rjbs
rjbs approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@rjbs rjbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct. Adding a test should be pretty simple, so I think that you should add a test, or maybe a bunch of tests. Still, approved nonetheless.

lib/PAUSE/pmfile.pm Outdated
}
=cut

# use feature 'class'; enabels class (and role, though not implemented yet)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type in comment: should be enables

rjbs
rjbs approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@rjbs rjbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 Looks good, and thanks for adding the tests!

@andk
Copy link
Owner

andk commented Apr 26, 2024

Thanks, applied and deployed just now!

@andk andk closed this Apr 26, 2024
@charsbar charsbar deleted the conditional_class_finder branch April 26, 2024 15:08
This was referenced Apr 26, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfsage wolfsage wolfsage approved these changes

@rjbs rjbs rjbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get a version from (class|role) NAME VERSION line
4 participants
@charsbar @andk @rjbs @wolfsage