Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflows by using prove (and removing a broken test for old pause99) #443

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions .github/workflows/perl-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
# Actions, but not how... -- rjbs, 2023-05-05
run: |
apt update
apt install -y rsync
apt install -y rsync default-mysql-server
- name: Install prereqs (cpanm, pinned versions)
# PAUSE is run (for now?) on v5.16, and the latest versions from the
# CPAN don't install on v5.16, so we install these version that do.
Expand All @@ -35,19 +35,21 @@ jobs:
# installing via cpanm that could, instead, be installed from apt. I
# may do that later, but for now, it's fine! -- rjbs, 2023-01-07
run: cpanm --notest --installdeps .
- name: Install yath and JUnit renderer
run: cpanm --notest Test2::Harness Test2::Harness::Renderer::JUnit
- name: Run the tests
# We disable Test::Perl::Critic because of a bug in
# Test2::Harness::Renderer::JUnit. See:
# https://github.com/cpanel/Test2-Harness-Renderer-JUnit/issues/16
# -- rjbs, 2023-05-05
run: |
NO_PERL_CRITIC=1 JUNIT_TEST_FILE="/tmp/test-output.xml" ALLOW_PASSING_TODOS=1 yath test --renderer=Formatter --renderer=JUnit -D
- name: Publish test report
uses: mikepenz/action-junit-report@v3
if: always() # always run even if the previous step fails
with:
check_name: JUnit Report
report_paths: /tmp/test-output.xml
run: prove -lr -j4 t
# - name: Install yath and JUnit renderer
# run: cpanm --notest Test2::Harness Test2::Harness::Renderer::JUnit
# - name: Run the tests
# # We disable Test::Perl::Critic because of a bug in
# # Test2::Harness::Renderer::JUnit. See:
# # https://github.com/cpanel/Test2-Harness-Renderer-JUnit/issues/16
# # -- rjbs, 2023-05-05
# run: |
# NO_PERL_CRITIC=1 JUNIT_TEST_FILE="/tmp/test-output.xml" ALLOW_PASSING_TODOS=1 yath test --renderer=Formatter --renderer=JUnit -D
# - name: Publish test report
# uses: mikepenz/action-junit-report@v3
# if: always() # always run even if the previous step fails
# with:
# check_name: JUnit Report
# report_paths: /tmp/test-output.xml

2 changes: 1 addition & 1 deletion cpanfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ requires 'Class::Singleton';
requires 'Crypt::Eksblowfish::Bcrypt';
requires 'DB_File';
requires 'DBI';
requires 'DBD::mysql';
requires 'DBD::mysql', '== 4.050';
requires 'DBD::SQLite';
requires 'Digest::SHA1';
requires 'Email::Address';
Expand Down
3 changes: 2 additions & 1 deletion t/pause_2017/lib/Test/PAUSE/MySQL.pm
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@ package Test::PAUSE::MySQL;

use Test::Builder ();
use Test::Requires qw(Test::mysqld);
use Test::Requires qw(File::Which);

BEGIN {
unless (-e '/usr/local/mysql/bin/mysql') {
unless (File::Which::which 'mysql') {
Test::Builder->new->skip_all("no mysql found, needed for this test")
}
}
Expand Down
24 changes: 0 additions & 24 deletions t/run_test_class_tests.t

This file was deleted.

30 changes: 0 additions & 30 deletions t/test_classes/Test/Pause99/Base.pm

This file was deleted.

96 changes: 0 additions & 96 deletions t/test_classes/Test/Pause99/Web/Auth.pm

This file was deleted.

26 changes: 0 additions & 26 deletions t/test_classes/Test/Pause99/Web/Base.pm

This file was deleted.

39 changes: 0 additions & 39 deletions t/test_classes/Test/Pause99/Web/ChangePassword.pm

This file was deleted.

40 changes: 0 additions & 40 deletions t/test_classes/Test/Pause99/Web/ReadOnlyPages.pm

This file was deleted.

Loading
Loading