Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Module::Faker "meta_munger" to test bad metadata #413

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

use Module::Faker "meta_munger" to test bad metadata #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d197b8
indexer tests: use the new meta_munger to create bogus metadata
rjbs Apr 28, 2019
f4ef74f
TestPAUSE: add a means to force rewrite_indexes
rjbs Apr 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed corpus/Provides-NoFile-0.50.tar.gz
View file
Open in desktop
Binary file not shown.
46 changes: 31 additions & 15 deletions t/lib/PAUSE/TestPAUSE.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,9 +313,8 @@ sub with_our_config {
$code->($self);
}

sub test_reindex {
my ($self, $arg) = @_;
$arg //= {};
sub _take_pause_action {
my ($self, $action) = @_;

$self->with_our_config(sub {
my $self = shift;
Expand Down Expand Up @@ -349,18 +348,7 @@ sub test_reindex {

die "stray mail in test mail trap before reindex" if @stray_mail;

if ($arg->{pick}) {
my $dbh = PAUSE::dbh();
$dbh->do("DELETE FROM distmtimes WHERE dist = ?", undef, $_)
for @{ $arg->{pick} };
}

PAUSE::mldistwatch->new({
sleep => 0,
($arg->{pick} ? (pick => $arg->{pick}) : ()),
})->reindex;

$arg->{after}->($self->tmpdir) if $arg->{after};
$action->();

my @deliveries = Email::Sender::Simple->default_transport->deliveries;

Expand All @@ -376,6 +364,34 @@ sub test_reindex {
});
}

sub rewrite_indexes {
my ($self) = @_;
my $action = sub {
PAUSE::mldistwatch->new({ sleep => 0 })->rewrite_indexes;
};

return $self->_take_pause_action($action);
}

sub test_reindex {
my ($self, $arg) = @_;
$arg //= {};
my $action = sub {
if ($arg->{pick}) {
my $dbh = PAUSE::dbh();
$dbh->do("DELETE FROM distmtimes WHERE dist = ?", undef, $_)
for @{ $arg->{pick} };
}

PAUSE::mldistwatch->new({
sleep => 0,
($arg->{pick} ? (pick => $arg->{pick}) : ()),
})->reindex;
};

return $self->_take_pause_action($action);
}

has _file_index => (
is => 'ro',
default => sub { {} },
Expand Down
19 changes: 13 additions & 6 deletions t/mldistwatch-big.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,12 +286,19 @@ subtest "case mismatch, authorized for original, desc. version" => sub {
subtest "sometimes, provides fields are empty" => sub {
my $pause = PAUSE::TestPAUSE->init_new;

# Key points:
# 1. dist version 0.50
# 2. meta provides has...
# a. package Provides::NoFile in a named file with version 1.5
# b. package Provides::NoFile::Nowhere with an undef file entry
$pause->upload_author_file(MYSTERIO => 'corpus/Provides-NoFile-0.50.tar.gz');
$pause->upload_author_fake(
MYSTERIO => 'Provides-NoFile-0.50.tar.gz',
{
meta_munger => sub {
$_[0]{provides} = {
"Provides::NoFile" => { file => "lib/Provides/NoFile.pm", version => "1.5" },
"Provides::NoFile::Nowhere" => { file => undef },
};

return $_[0];
},
}
);

my $result = $pause->test_reindex;

Expand Down