-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] issue262 fixing SQL-Hint deleting when clearing script from comments #792
Conversation
[fix] issue262 fixing problem w/ removing SQL-Hints w/ comments
Hi, @andialbrecht! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skryzh hey, thanks for the pull request! Looks good so far, I've got just some nitpicks.
[feature] deleting envs from .gitignore, creating test for SQL-Hints
[feature] returning .gitignore to previous version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks and sorry for the delay.... busy times, as usual :-D
It's ok, same :D |
#Fixing SQL-Hint deleting when clearing script from comments
#262
What is done:
Before submitting your pull request please have a look at the
following checklist:
pytest
)flake8
)In addition, please take care to provide a proper description
on what your change does, fixes or achieves when submitting the
pull request.