Add purls in sarif report #2254
Open
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Liontos <[email protected]>
kzantow
reviewed
Nov 19, 2024
Signed-off-by: George Liontos <[email protected]>
kzantow
reviewed
Nov 22, 2024
grype/presenter/sarif/presenter.go
Outdated
| @@ -122,6 +122,7 @@ func (pres *Presenter) sarifRules() (out []*sarif.ReportingDescriptor) { | |||
| // For GitHub reportingDescriptor object: | |||
| // https://docs.github.com/en/code-security/code-scanning/integrating-with-code-scanning/sarif-support-for-code-scanning#reportingdescriptor-object | |||
| "security-severity": pres.securitySeverityValue(m), | |||
| "purls": [...]string{m.Package.PURL}, | |||
There was a problem hiding this comment.
Thanks for the updates here @GeorgeLS. We should probably only add this field if we have a non-empty PURL instead of creating arrays of empty strings, like this results in -- in other words: I think the tests would be reverted because we shouldn't see "purls": [""],, and we should add something that validates when a PURL is set, it is output as expected.
There was a problem hiding this comment.
Yeah you are right. I will change asap. 🙏
Signed-off-by: George Liontos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
Seems like that
purlsare missing from Sarif reports ofgrype.I attempted adding those in the Sarif report. In order to do that I had to copy the
deriveBomReffunction that is being used in CycloneDx as well.I tried making
deriveBomRefa member function ofPackagetype in order to avoid duplication but I couldn't build the project locally.Thanks,
George