-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include file location in table output (#1199) #1275
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: James Neate <[email protected]>
Signed-off-by: James Neate <[email protected]>
4e8df15
to
97d3292
Compare
This one is also going to go in (or at least have this as an option) after we get the UI for grype updated with the new https://github.com/anchore/clio library |
Hi @jneate, thanks for this. In an effort to keep the table view as concise as possible, we are thinking it might make sense to create a "table-locations.tmpl" template that includes the locations of the vulnerability. What do you think about that, instead of changing the default table view? |
Although it's not exactly the same as the table output, a couple options to fairly easily get the location are:
|
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
This could hopefully resolve #1199
I wasn't 100% sure which types to exclude so I started with Apk,Deb&Rpm - placed the boolean flag into a map in case they need to be driven by config in the future.
Regarding the tests, I just thought it'd be nice to have a non-distro package in the output so added a 3rd match in models_helpers and updated the other output snapshots. I didn't think there was any gain adding a 4th package which is why the CreateRow test just recycles the values from other objects instead of being created from the helper.
Attached some example output below from various runs.
Scanning: openjdk:17.0.1-jdk-oracle
Scanning: quay.io/cilium/hubble-ui-backend:v0.10.0
Scanning Directory:
Scanning Directory: