Use same date for all images #58
Conversation
|
I don't think that works - the images are rebuilt daily, and that will all use the same commit, no? |
|
Actually I thought the same but tested and found that CIRRUS_CHANGE_TIMESTAMP is different for cron jobs. For example: These four tasks have same commit hash: d1ef15b https://cirrus-ci.com/task/6486504743108608 -> CIRRUS_CHANGE_TIMESTAMP=1679607024158 |
|
Oh, interesting. |
.cirrus.yml
Outdated
| @@ -17,6 +17,15 @@ env: | |||
| # GCP_REGION | |||
| # GCP_REPO | |||
|
|
|||
| # Get the same date for the tasks. CIRRUS_CHANGE_TIMESTAMP is | |||
| # timestamp of when the commit is pushed in ms. Add 500ms to | |||
There was a problem hiding this comment.
Should note that the timestamp does change when task is triggered by cron.
.cirrus.yml
Outdated
| # timestamp of when the commit is pushed in ms. Add 500ms to | ||
| # round up to the nearest second then convert it to date. Another method | ||
| # is used at the Windows docker-builder task because $CIRRUS_ENV can't | ||
| # be updated and this method is not working on PowerShell. |
There was a problem hiding this comment.
Why can't CIRRUS_ENV be updated? IIRC it was broken at some point, but after I reported that, cirrus implemented a fix?
There was a problem hiding this comment.
I couldn't update them on Windows, it says:
'Failed collect CIRRUS_ENV subsystem results: CIRRUS_ENV file should contain lines in KEY=VALUE format'
but it is already in KEY=VALUE format.
There was a problem hiding this comment.
I suspect that's an encoding issue. Powershell will write utf-16 by default.
|
Hm. I wonder if it's going to be confusing that an image with newer packages could have an older timestamp? |
|
What about this alternative: We have a first task that does nothing but export the date into a text artifcact, that the other tasks then use to determine the timestamp? |
I didn't understand this, doesn't that text file stay on first task's machine, how will the other tasks reach it? |
This should happen rarely, right? Otherwise, yes. It can be confusing. |
https://cirrus-ci.org/guide/writing-tasks/#current-build-artifacts Even though that documents .zip, you can download individual artifacts directly. E.g. for Note that that does not include the task id of the openbsd build, just the build id shared by all the tasks. For this purpose it'd be good to use a task name that doesn't include spaces, or has an alias without spaces. |
nbyavuz
force-pushed
the
image-creation-features
branch
from
6d2c7d9 to
0e7c02b
Compare
There was a problem hiding this comment.
I wonder if a simpler solution could be implemented with starlark:
https://cirrus-ci.org/guide/programming-tasks/
We could make the starlark script emit something like
env:
IMAGE_DATE: iso-date-stringwhich I think should suffice? We already do that for some vars, so it should be easy:
https://github.com/anarazel/pg-vm-images/blob/main/.cirrus.star
Apparently this should give us the time:
https://github.com/qri-io/starlib/blob/master/time/doc.go#LL27C1-L27C1
.cirrus.yml
Outdated
| # timestamp of when the commit is pushed in ms. Add 500ms to | ||
| # round up to the nearest second then convert it to date. Another method | ||
| # is used at the Windows docker-builder task because $CIRRUS_ENV can't | ||
| # be updated and this method is not working on PowerShell. |
nbyavuz
force-pushed
the
image-creation-features
branch
from
0e7c02b to
f2f6a7e
Compare
It seems time is not available in Cirrus Starlark. |
nbyavuz
force-pushed
the
image-creation-features
branch
2 times, most recently
from
99ddf75 to
a27f448
Compare
Export date to artifact on one task which other tasks are depended. Then download this artifact on other tasks and use it to set date.
nbyavuz
force-pushed
the
image-creation-features
branch
from
a27f448 to
81108f3
Compare
There is a CIRRUS_CHANGE_TIMESTAMP variable which is timestamp of when the commit is pushed. Convert that timestamp to date and use it at the images. So, all of the images' date part will be the same. Then we can use and update these images at the other CI tasks.A downside comes to my mind, if the image is created and we re-run CI; it will fail because the image name will be same.New method is:
Export date to artifact on one task which other tasks are depended. Then download this artifact on other tasks and use it to set date.