pwm_gen_tb: Add tb for axi_pwm_gen #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
alin724
commented
Nov 12, 2023
alin724
commented
- pwm_gen_tb - configuration task - configure period, width, offset of different channels;
- HDL repo PR;
Signed-off-by: Alin-Tudor Sferle <[email protected]>
IstvanZsSzekely
requested changes
Jan 8, 2024
| $display("[%t] axi_pwm_gen started.", $time); | ||
| #100000; | ||
|
|
||
| axi_write (`AXI_PWMGEN + 32'h00000010, 'h2); // stop PWM_GEN |
There was a problem hiding this comment.
'h2 should be changed to 'h1. 'h2 loads the current configuration.
There was a problem hiding this comment.
Also, shouldn't we use the following format instead of manually setting the address?
axi_write (AXI_PWMGEN + GetAddrs(REG_RSTN), SET_REG_RSTN_RESET(1));
StancaPop
requested changes
Feb 7, 2024
| .pwm_gen_o_13 (pwm_gen_o_13), | ||
| .pwm_gen_o_14 (pwm_gen_o_14), | ||
| .pwm_gen_o_15 (pwm_gen_o_15), | ||
|
|
| input pwm_gen_o_13, | ||
| input pwm_gen_o_14, | ||
| input pwm_gen_o_15, | ||
|
|
|
|
||
| task test_config; | ||
| begin | ||
| #100 axi_write (`AXI_PWMGEN + GetAddrs(REG_RSTN), `SET_REG_RSTN_RESET(0)); // PWM_GEN reset in regmap (ACTIVE HIGH) |
There was a problem hiding this comment.
The #100 delays can be removed in all these axi writes, as they do not affect the functionality and are not mandatory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.