Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Projects: ad2s1210: Add support for ad2s1210 #24

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Projects: ad2s1210: Add support for ad2s1210 #24

merged 2 commits into from
Dec 11, 2023

Conversation

ahaslam2
Copy link
Collaborator

The AD2S1210 is a complete 10-bit to 16-bit resolution tracking resolver-to-digital converter

@pamolloy pamolloy added this to the BayLibre September Delivery milestone Sep 16, 2023
@ahaslam2 ahaslam2 marked this pull request as ready for review September 18, 2023 08:23
@ahaslam2 ahaslam2 requested a review from pamolloy September 18, 2023 10:29
@ahaslam2 ahaslam2 force-pushed the ahaslam/ad2s1210_rc1 branch 2 times, most recently from 280efe3 to d3581ee Compare September 19, 2023 14:28
@ahaslam2 ahaslam2 mentioned this pull request Sep 19, 2023
Open
2 tasks
@ahaslam2 ahaslam2 force-pushed the ahaslam/ad2s1210_rc1 branch 3 times, most recently from 5b4d518 to f38e2f6 Compare September 21, 2023 15:08
@ahaslam2 ahaslam2 force-pushed the ahaslam/ad2s1210_rc1 branch from f38e2f6 to d12fa5d Compare October 2, 2023 09:27
@CLAassistant
Copy link

CLAassistant commented Oct 3, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mphalke
Copy link
Collaborator

mphalke commented Oct 4, 2023

@ahaslam2 Please sign the CLA before we start reviewing this PR

@mphalke mphalke requested review from ribdp and jansunil October 4, 2023 04:52
@ahaslam2 ahaslam2 force-pushed the ahaslam/ad2s1210_rc1 branch from d12fa5d to bb8771f Compare October 4, 2023 11:05
@ahaslam2 ahaslam2 force-pushed the ahaslam/ad2s1210_rc1 branch from 99bd8b8 to 531b231 Compare December 4, 2023 14:40
@ahaslam2
Copy link
Collaborator Author

ahaslam2 commented Dec 4, 2023

Changelog:

  • rename active_count to active_count
  • use gpio_ops instead of mbed_gpio_ops
  • remove print in conftest.py
  • increase Copyright year
  • limit test pass range to 2.5 and 3.5 rad.
  • remove data sample loop in test_ad2s1210_example.py

@ahaslam2 ahaslam2 force-pushed the ahaslam/ad2s1210_rc1 branch from 531b231 to e0c5a2d Compare December 5, 2023 08:46
@ahaslam2
Copy link
Collaborator Author

ahaslam2 commented Dec 5, 2023

Change log:

  • change ASZS-BREAKOUT to ADZS-BRKOUT in readme

mphalke
mphalke reviewed Dec 5, 2023
View reviewed changes
projects/ad2s1210_iio/README.txt Outdated Show resolved Hide resolved
projects/ad2s1210_iio/app/app_config_mbed.c Outdated
.spi_clk_pin = SPI_SCK,
.spi_miso_pin = SPI_HOST_SDI,
.spi_mosi_pin = SPI_HOST_SDO,
.use_sw_csb = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any particular reason of using software CSB? As per our experience with Mbed, software CSB adds-up some extra dead time during data transfer, whereas with hardware CSB this dead time is less compared to software CSB. This is expected as we are explicitly toggling CS pin when it is configured as software CSB, while when it is configured as h/w CSB, toggling of CSB happen within Mbed layer, so this extra overhead is less.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i need to try that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hw CS works too. i think this was left over from the time i was trying to get the board to work.
i will change it.

projects/ad2s1210_iio/tests/func/ad2s1210.py Outdated Show resolved Hide resolved
@mphalke mphalke requested review from jansunil, ribdp and mphalke December 5, 2023 11:18
@ahaslam2 ahaslam2 force-pushed the ahaslam/ad2s1210_rc1 branch from e0c5a2d to 16f222e Compare December 5, 2023 15:58
@ahaslam2
Copy link
Collaborator Author

ahaslam2 commented Dec 5, 2023

Change log:

  • remove ad2s1210.py use the one in pyadi-iio
  • use hw cs instead of sw cs
  • fix another ASZS-BREAKOUT -> ASZS-BRKOUT in readme

mphalke
mphalke previously approved these changes Dec 6, 2023
View reviewed changes
@mphalke
Copy link
Collaborator

mphalke commented Dec 6, 2023

looks good to me unless any comments from @jansunil and @ribdp

@ahaslam2
libraries: Update No-os library
1cddee6 
This updates the no-os library to include the
driver changes for ad2s1210

Signed-off-by: Axel Haslam <[email protected]>
@ahaslam2
Projects: ad2s1210: Add support for ad2s1210
eed63a2 
The AD2S1210 is a complete 10-bit to 16-bit resolution tracking
resolver-to-digital converter

Signed-off-by: Axel Haslam <[email protected]>
@ahaslam2 ahaslam2 force-pushed the ahaslam/ad2s1210_rc1 branch from 16f222e to eed63a2 Compare December 7, 2023 12:36
@ahaslam2
Copy link
Collaborator Author

ahaslam2 commented Dec 7, 2023

changelog:

  • fix typo in readme doc

@mphalke mphalke self-requested a review December 11, 2023 09:32
@mphalke mphalke merged commit fc82199 into main Dec 11, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ribdp ribdp ribdp approved these changes

@jansunil jansunil jansunil approved these changes

@mphalke mphalke mphalke approved these changes

@pamolloy pamolloy Awaiting requested review from pamolloy

@mike-bradley mike-bradley Awaiting requested review from mike-bradley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
BayLibre September Delivery
Development

Successfully merging this pull request may close these issues.
6 participants
@ahaslam2 @CLAassistant @mphalke @jansunil @ribdp @pamolloy