Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to handle Events and Labels. #1175

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

slothdnk
Copy link

@slothdnk slothdnk commented Jun 7, 2024

PR Description

Make Label's work
Make Events register with correct path.
Show Label in debug when adding devices.

PR Type

  • [ X] Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • [X ] I have conducted a self-review of my own code changes
  • I have commented new code, particulary complex or unclear areas
  • [X ] I have checked that I did not intoduced new warnings or errors (CI output)
  • [X ] I have checked that components that use libiio did not get broken
  • [ X] I have updated the documentation accordingly (GitHub Pages, READMEs, etc)

@pcercuei
Copy link
Contributor

You'll have to write better commit descriptions, that explain what each commit is fixing (or modifying) and why the change is needed; and also sign-off your commits (with git commit -s, or manually adding a Signed-off-by: line at the end of your commit description, see the git log for examples).

Since nothing is explained, I don't know what you're trying to fix with the "Make events register with correct path" commit. It looks wrong to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants